Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1805 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 202 202
Lines 10908 10908
=======================================
Hits 9982 9982
Misses 926 926 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schlunma
approved these changes
Nov 18, 2022
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Thanks Bouwe! Can we close ESMValGroup/ESMValTool#2924 after that? Or do we want to leave that open until this is solved in iris?
Member
Author
|
We might want to keep it open until the iris issue is solved, so it is easy to find in case someone runs into it |
Contributor
|
Thanks! Shall we have the same pin for the Tool then? |
Contributor
Sounds good to me! |
bouweandela
added a commit
that referenced
this pull request
Nov 21, 2022
This reverts commit f1707f8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pin netCDF4 < 1.6.1
See #1723, ESMValGroup/ESMValTool#2924, SciTools/iris#5016
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: